Enable real-time clock in prism by default. - #36473
Merged
Merged
Conversation
shunping
changed the title
Collaborator
Author
|
R: @damccorm |
shunping
marked this pull request as ready for review
October 11, 2025 02:38
Collaborator
Author
|
CC: @lostluck |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
shunping
changed the title
Contributor
|
I am going to get to it today. |
lostluck
reviewed
Oct 13, 2025
| timersProcessingTimePipelineBuilder(func(s beam.Scope) beam.PCollection { | ||
| now := time.Now() | ||
| return periodic.Impulse(s, now, now.Add(10*time.Second), 0, false) | ||
| return periodic.Impulse(s, now, now.Add(10*time.Second), 5*time.Second, false) |
Contributor
There was a problem hiding this comment.
Is the goal here is to have the transform fire twice, not once?
lostluck
approved these changes
Oct 13, 2025
Collaborator
Author
|
Thanks a lot for your time to review! |
Collaborator
Author
|
After this PR, real-time clock is enabled in prism by default. So I think we can close #32786. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adjust some processing time timer tests so that they can finish before server timeout.